-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coq-native support (if available) as per CEP 48 #45
Conversation
d33581a
to
f567af0
Compare
* Bump dune-project accordingly
5108738
to
6f737bb
Compare
Hi @strub, the PR is almost ready; I specifically prepared it in a "TDD" way. An upside of the proposed patch is that it is not necessary to exclude Coq versions before 8.12.1. However the job @ejgallego do you have a idea of what's missing? |
On second thought I guess this is precisely what we had documented in this section: Roughly, in order to ensure that I'll try do to this soon. Cc @proux01 @CohenCyril FYI |
We can also just forget about Coq < 8.13 and coq-native, it would already be great to have things working with Coq >= 8.13. I'm not sure there are much users of Coq < 8.13 and native_compute around. native_compute with anything using multinomials is broken for more than six months now, having it work even with Coq >= 8.13 would be a huge progress. |
I see what you mean, but wouldn't it be a pity not to take advantage of coq-native for at least 8.12?
As the fix is simple and documented (item 3 of the CEP 48, which BTW should have been applicable just as well for Coq 8.5+).
Otherwise, if we give up this item-3 idea, this would strongly restrict the number of Coq versions we'll be able to compare for running ValidSDP benchmarks, for example.
Le 28 septembre 2021 08:49:09 GMT+02:00, Pierre Roux ***@***.***> a écrit :
…We can also just forget about Coq < 8.13 and coq-native, it would already be great to have things working with Coq >= 8.13. I'm not sure there are much users of Coq < 8.13 and native_compute around. native_compute with anything using multinomials is broken for more than six months now, having it work even with Coq >= 8.13 would be a huge progress.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#45 (comment)
|
I really don't care. My point is rather: don't put too much effort in supporting older versions as there isn't much use for it. Of course, if it's easy why not. But I'd really prefer something working with current versions to something not working at all. |
Same for me. |
OK. Regarding the effort involved, I'd say the vast majority of this effort is already done! (discussing and refining the CEP, preparing and merging the coq-native package, proposing a workflow to adapt packaging for both dune and coq_makefile). Anyway, I agree with your pragmatism:
|
* can be reverted anytime after the merge of coq/opam#1835 and the rebuild of `mathcomp/mathcomp:1.12.0-coq-8.12`
done. Does this look good to you? |
LGTM However, this looks quite heavy, we'll definitely need to fix dune when 3.0 will be there to avoid such painful work. |
@erikmd indeed that error usually happens when the native files for a depending library weren't compiled. |
Fix coq-mathcomp-multinomials.dev according to math-comp/multinomials#45
* For details, see: - https://opam.ocaml.org/packages/coq-native/ - CEP 48 <https://github.com/coq/ceps/blob/master/text/048-packaging-coq-native.md#note-to-library-developers-and-package-maintainers> * can be reverted anytime after the merge of coq/opam#1835 and the rebuild of `mathcomp/mathcomp:1.12.0-coq-8.12`
Subsumes and replaces PR #41